perf(share): stop over-fetching grouped shared-with results#61754
Open
joshtrichards wants to merge 1 commit into
Open
perf(share): stop over-fetching grouped shared-with results#61754joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
2. developing
joshtrichards
requested review from
Altahrim,
come-nc,
leftybournes and
salmart-dev
and removed request for
a team
joshtrichards
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the group branch so it uses the accumulated grouped-share count and stop scanning once
offset + limitunique shares are collected.The previous logic used
count($shares), which stays empty until after group share resolution, so each chunk could query up to the full limit. This caused unnecessary DB work for users in many groups.Checklist
3. to review, feature component)stable32)AI (if applicable)