Skip to content

Clean up Android testing devices#1880

Open
AustinBenoit wants to merge 3 commits into
mainfrom
fix-s25-ultra-ftl-version
Open

Clean up Android testing devices#1880
AustinBenoit wants to merge 3 commits into
mainfrom
fix-s25-ultra-ftl-version

Conversation

@AustinBenoit

Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Trying to prevent android flakes. The pa3q only has version 35.
The Pixel2 non arm doesn't come up anymore as a target too. It still works but I will remove it anyways.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration test will run


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

Firebase Test Lab only supports Android 35 for the Galaxy S25 Ultra (pa3q),
not Android 36. Using version 36 caused FTL to decline/skip the test run
with exit code 18 (Outcome: Skipped).

Verified using:
gcloud firebase test android models list
- Set emulator_ftl_target (baseline) to API 26 (oldest FTL emulator version) and removed the invalid non-ARM Pixel2 model.
- Set emulator_ftl_latest (latest) to API 35 (Android 15) and removed Pixel2.arm since it only supports up to API 33.
Revert the target and latest emulator versions back to their original values of 28 and 32 respectively.
Keep only the removal of the invalid/obsolete Pixel2 (non-arm) device from emulator_ftl_target.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GitHub Actions matrix configuration in scripts/gha/print_matrix_configuration.py. Specifically, it downgrades the target version for the Galaxy S25 Ultra (model=pa3q) from 36 to 35, and removes the non-ARM Pixel2 emulator target (model=Pixel2,version=28) from the FTL emulator targets. There are no review comments, so I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants