test: fix Session tests execution in random order#10370
Open
gr8man wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ref: #9968
This PR fixes an issue that caused tests in the
Sessioncomponent to randomly fail with database errors (e.g.,SQLite3Exception: table 'db_type_test' already exists) when executed with--order-by=random.The root cause was traced to
AbstractHandlerTestCase::setUp(), whereparent::setUp()was being invoked before evaluating if the test should be skipped due to unsupported database drivers. Sinceparent::setUp()runsDatabaseTestTrait's migrations and initializes the test database (SQLite by default), skipping the test right after it meant thattearDown()was never executed by PHPUnit. As a result, the database was left dirty with leftover tables, which randomly broke subsequent database tests.Moving
markTestSkipped()aboveparent::setUp()cleanly skips the unsupported tests without initializing the database, ensuring 100% stability when running the suite in random order.Checklist: