[ARITH][TIR] Track positive loop extents in analyzer visitors#19927
Open
tlopex wants to merge 1 commit into
Open
[ARITH][TIR] Track positive loop extents in analyzer visitors#19927tlopex wants to merge 1 commit into
tlopex wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates IRMutatorWithAnalyzer and IRVisitorWithAnalyzer to register a constraint that the loop extent is positive (extent > 0) when visiting a loop's body, allowing for better simplification of expressions inside the loop. A test case is added to verify this behavior. One issue was identified in IRMutatorWithAnalyzer::VisitStmt_ where the constraint is registered using the original op->extent instead of the mutated extent, which can make the constraint ineffective if the extent expression is mutated. It is recommended to use the mutated extent instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
tlopex
force-pushed
the
fix-affine-grid-3d-test-helper
branch
from
eaf5821 to
5f90ee3
Compare
Member
Author
|
cc @LeiWang1999 |
Contributor
|
cc @LJC00118 |
|
LGTM! |
tqchen
approved these changes
Jul 2, 2026
Member
|
@tvm-bot run |
Member
|
@tvm-bot rerun |
Contributor
|
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/28610487289 Detailswith response |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
IRMutatorWithAnalyzerandIRVisitorWithAnalyzerto add the constraintloop_extent > 0while visiting aForNodebody.If execution reaches the loop body, the loop must have at least one iteration, so the body context can safely assume the extent is positive. The constraint is scoped only to the loop body, leaving the loop header expressions (
min,extent,step) outside of this assumption.